[U-Boot] [PATCH] powerpc/85xx: Add workaround for errata USB-14 (enable on P204x/P3041/P50x0)
xulei
B33228 at freescale.com
Tue Mar 5 11:07:58 CET 2013
Hello, Wolfgang
Thank you, will modify it in the next version.
Regards
Lei
On Monday, 2013-03-04 at 10:24 +0100, Wolfgang Denk wrote:
> Dear xulei,
>
> In message <1362368146-738-1-git-send-email-B33228 at freescale.com> you wrote:
> >
> > + /* On P204x/P304x/P50x0 Rev1.0, USB transmit will result internal
> > + * multi-bit ECC errors, which has impact on performance, so software
> > + * should disable all ECC reporting from USB1 and USB2 by setting bits
> > + * 16 and 17 to 1 in the register at DCSRBASE + 0x0002_0520.
> > + */
> > +#ifdef CONFIG_SYS_FSL_ERRATUM_USB14
> > + if (IS_SVR_REV(get_svr(), 1, 0)) {
> > + void *p;
> > + p = (void *)CONFIG_SYS_DCSRBAR + 0x20520;
> > + setbits_be32(p, 3 << (31 - 17));
> > + }
> > +#endif
>
> Please move the comment inside the #ifdef block.
>
> Best regards,
>
> Wolfgang Denk
>
More information about the U-Boot
mailing list