[U-Boot] [PATCH] MAKEALL: allow regex matches for -s option

Wolfgang Denk wd at denx.de
Tue Mar 5 22:37:37 CET 2013


Dear Stephen Warren,

In message <1362518101-5742-1-git-send-email-swarren at wwwdotorg.org> you wrote:
> From: Stephen Warren <swarren at nvidia.com>
> 
> This allows:
> 
> MAKEALL -s tegra*
> 
> to replace:
> 
> MAKEALL -s tegra20 -s tegra30 -s tegra114
> 
> Signed-off-by: Stephen Warren <swarren at nvidia.com>
> ---
>  MAKEALL |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MAKEALL b/MAKEALL
> index 5b06c54..0ed6986 100755
> --- a/MAKEALL
> +++ b/MAKEALL
> @@ -101,9 +101,9 @@ while true ; do
>  	-s|--soc)
>  		# echo "Option SoC: argument \`$2'"
>  		if [ "$opt_s" ] ; then
> -			opt_s="${opt_s%)} || \$6 == \"$2\")"
> +			opt_s="${opt_s%)} || \$6 == \"$2\" || \$6 ~ /$2/)"

Is this actually correct?  I see 2 x closing parens here, with no
matching open parens?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Remember, an int is not always 16 bits. I'm  not  sure,  but  if  the
80386  is one step closer to Intel's slugfest with the CPU curve that
is aymptotically approaching a real machine, perhaps an int has  been
implemented as 32 bits by some Unix vendors...?       - Derek Terveer


More information about the U-Boot mailing list