[U-Boot] [PATCH] MAKEALL: allow regex matches for -s option

Tom Rini trini at ti.com
Wed Mar 6 00:08:50 CET 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/05/2013 04:43 PM, Stephen Warren wrote:
> On 03/05/2013 02:37 PM, Wolfgang Denk wrote:
>> Dear Stephen Warren,
>> 
>> In message
>> <1362518101-5742-1-git-send-email-swarren at wwwdotorg.org> you
>> wrote:
>>> From: Stephen Warren <swarren at nvidia.com>
>>> 
>>> This allows:
>>> 
>>> MAKEALL -s tegra*
>>> 
>>> to replace:
>>> 
>>> MAKEALL -s tegra20 -s tegra30 -s tegra114
>>> 
>>> Signed-off-by: Stephen Warren <swarren at nvidia.com> --- MAKEALL
>>> |    4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
>>> 
>>> diff --git a/MAKEALL b/MAKEALL index 5b06c54..0ed6986 100755 
>>> --- a/MAKEALL +++ b/MAKEALL @@ -101,9 +101,9 @@ while true ;
>>> do -s|--soc) # echo "Option SoC: argument \`$2'" if [ "$opt_s"
>>> ] ; then -			opt_s="${opt_s%)} || \$6 == \"$2\")" +
>>> opt_s="${opt_s%)} || \$6 == \"$2\" || \$6 ~ /$2/)"
>> 
>> Is this actually correct?  I see 2 x closing parens here, with
>> no matching open parens?
> 
> Yes, it's confusing, but I believe correct (although I didn't
> actually test multiple -s options).

Can you try MAKEALL -s tegra* -s omap* and see what happens?

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRNnsCAAoJENk4IS6UOR1W+UIP/0P33LEM7KJT51vdmiPvVDof
NSj+ybdkRd5GZIF9hPnWpO7evFp2BfQNk3KhhmuAOcuiVl+ChBoTwybFpwQjB8KD
BVzLK7qcrjmzmbKV4jrkkZTyp3ejSrFJbrz0LNcPY+UmMyWRUSccAMPtVj7VMRrT
bVYeBgki6AyxljQU2Wx8DbWsyavif8+OZTZSDw4bHR0SCYLaAHmA4Uox4p5krsDd
2dkRuSERcFq2LEB+ynvuCbBjzuYDAYgumdKg8i4BK0gHLP6kzIX7bgrHA8AzHibR
+URnMNrkIlu7qzQIJ01x5k3TIOpkjY30FxAbi04ve2EUHPtThq4e0h5ldEjZi+Cd
XqwM8iUpIhjN5Medk7e+iGLxCPMWJhPILh3XpaV/uW3hGsdIQTbgKzxvlFOo/Vbg
SvlAtTPI4l/P+oB4Fln9aT3bYyyLGvp2eBVhCtasOtJvjykl1ZQJLnNDBg/hXURo
18+BZwCdD8wyP/bOmVgO/PUG2WKlNH1+Dv/7wxILuO1KLsU21bsVBlE0J+GZouxd
f6Q9tkSPtikAQFfy9+MXVopjs6RCQn8VMiNQmx9CBVauXux7Al0JelzRo4vN8TiV
dgCtLlq8eHyRnZTSLRX7AJ3iFNmLi0jDZCE1DDGJuQbQ2OrfjFeHMrKix/Y31tH2
TpBV5fMbQAKk99NB6EDX
=+z/Q
-----END PGP SIGNATURE-----


More information about the U-Boot mailing list