[U-Boot] [PATCH v9 15/30] autoconfig.mk: Make it possible to define configs from other configs

Benoît Thébaudeau benoit.thebaudeau at advansee.com
Thu Mar 7 12:38:04 CET 2013


Dear Wolfgang Denk,

On Thursday, March 7, 2013 7:57:13 AM, Wolfgang Denk wrote:
> Dear Benoît Thébaudeau,
> 
> In message <1362596377-5827-15-git-send-email-benoit.thebaudeau at advansee.com>
> you wrote:
> >
> > +	# ... and from configs defined from other configs
> > +	s/="\(CONFIG_[A-Za-z0-9_][A-Za-z0-9_]*\)"/=$(\1)/;
> 
> Should we not remove the lower case letters here?  Such are not
> supposed to be used in macro names.

I don't think so. They're indeed not supposed to be used, but there are perhaps
exceptions somewhere, and it's not the purpose of this script to enforce such a
rule. Also, note that lowercase letters are used in the main line filter of this
script too.

But if this is a strong requirement from you to remove lowercase letters here,
just tell me, and I'll make the change. In that case, should the main line
filter be changed too?

Best regards,
Benoît


More information about the U-Boot mailing list