[U-Boot] [PATCH v4 1/2] usb: ehci: exynos: Fix multiple FDT decode

Simon Glass sjg at chromium.org
Thu Mar 7 14:49:41 CET 2013


On Wed, Mar 6, 2013 at 12:48 AM, Vivek Gautam <gautam.vivek at samsung.com> wrote:
> With current FDT support driver tries to parse device node
> twice in ehci_hcd_init() and ehci_hcd_stop(), which shouldn't
> happen ideally.
> Making provision to store data in a global structure and thereby
> passing its pointer when needed.
>
> Signed-off-by: Vivek Gautam <gautam.vivek at samsung.com>

Acked-by: Simon Glass <sjg at chromium.org>

> ---
>
> Changes from v3:
>  - Checking for error return in exynos_usb_parse_dt() and returning
>    there only in case of failure for DT systems.
>  - Removed unnecesassry parentheses.
>
> Changes from v2:
>  - Using hcd as "struct ehci_hccr *" rather than "unsigned int" to
>    avoid unnecessary typecasting later in the code.
>  - Further using local variable of type "fdt_addr_t" in
>    exynos_usb_parse_dt() and modifying the code as required.
>
> Changes from v1:
>  - Added patch to fix problem of multiple FDT decode.
>
>  drivers/usb/host/ehci-exynos.c |   44 ++++++++++++++-------------------------
>  1 files changed, 16 insertions(+), 28 deletions(-)
>


More information about the U-Boot mailing list