[U-Boot] [PATCH 1/2 v3] Exynos5: spl: Reorganize mem_timing struct to gain space in spl

Simon Glass sjg at chromium.org
Fri Mar 8 04:33:50 CET 2013


Hi Akshay,

On Wed, Mar 6, 2013 at 6:22 AM, Akshay Saraswat <akshay.s at samsung.com> wrote:
> Distributes struct mem_timings into new different structures
> to gain space in spl by removing necessity of maintaining
> two big and almost similar mem_timings instances.
>
> Signed-off-by: Akshay Saraswat <akshay.s at samsung.com>
> ---
> Changes since v1:
>         - None.
>
> Changes since v2:
>         - Replaced non_spl_clock_div with clock_div.
>         - Replaced ns_clk_div with clk_div.
>         - Added few new comments.
>         - Modified few comments.
>
>  board/samsung/smdk5250/clock_init.c    | 177 ++++++++++++---------------------
>  board/samsung/smdk5250/clock_init.h    |  74 ++++++++++----
>  board/samsung/smdk5250/dmc_common.c    |  40 ++++----
>  board/samsung/smdk5250/dmc_init_ddr3.c | 116 +++++++++++----------
>  board/samsung/smdk5250/setup.h         |  15 ++-
>  5 files changed, 211 insertions(+), 211 deletions(-)

Is it possible to move the non-spl code into a separate file? I think
it would be better if SPL includes one clock_init (memory, boot
peripheral) and U-Boot includes the other, and that there is nothing
in common. Would that work?

Regards,
Simon


More information about the U-Boot mailing list