[U-Boot] [PATCH v7 07/31] Define CONFIG_SYS_LEGACY_BOARD everywhere

Wolfgang Denk wd at denx.de
Fri Mar 8 09:31:40 CET 2013


Dear Simon Glass,

In message <1362715633-20556-8-git-send-email-sjg at chromium.org> you wrote:
> We are introducing a new unified board setup and we want this to
> be the default. So we need to opt all architectures out first.
...

> +- CONFIG_SYS_LEGACY_BOARD
> +	This option should not be defined by board config files.
> +	This is an internal CONFIG defined by architectures which do not
> +	support CONFIG_SYS_GENERIC_BOARD. It is used as a check that boards
> +	don't accidentally define CONFIG_SYS_GENERIC_BOARD when their
> +	architecture cannot support it, and U-Boot would then either not
> +	build or not work. When an architecture supports generic board,
> +	then CONFIG_SYS_LEGACY_BOARD can be removed from the architecture's
> +	config.mk file so that generic board becomes available.

Hm... I understand that you selected the ...LEGACY_BOARD name to make
it easy to see the relation to ...GENERIC_BOARD?  But then, the name
is misleading - if my understanding is correct, then ...LEGACY_BOARD
is NOT a _board_ specific config option, but an _architecture_ speci-
fic one.

Actually this is then not a real CONFIG_SYS_ thing at all.

Should we rather use something like __HAVE_ARCH_GENERIC_BOARD ??
This would also make clear this is an internal macro only.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
No journaling file system can recover your data if the disk dies.
                                 - Steve Rago in <D4Cw1p.L9E at plc.com>


More information about the U-Boot mailing list