[U-Boot] [PATCH] Add U_BOOT_TIMESTAMP definition

Wolfgang Denk wd at denx.de
Sat Mar 9 08:09:54 CET 2013


Dear Matt,

In message <1345733053-5023-1-git-send-email-matt at genesi-usa.com> you wrote:
> This gives us a string like "20120822150855" which encodes the build time.
> 
> This allows automated version checking and flashing of U-Boot to be performed,
> for example, in boot.scr files (or scripting in general).

I just noticed that this was never applied.  Sorry...

>  Makefile |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Makefile b/Makefile
> index 1df4c1d..c042206 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -664,6 +664,7 @@ $(TIMESTAMP_FILE):
>  		@mkdir -p $(dir $(TIMESTAMP_FILE))
>  		@LC_ALL=C date +'#define U_BOOT_DATE "%b %d %C%y"' > $@.tmp
>  		@LC_ALL=C date +'#define U_BOOT_TIME "%T"' >> $@.tmp
> +		@LC_ALL=C date +'#define U_BOOT_TIMESTAMP "%Y%m%d%H%M%S"' >> $@.tmp
>  		@cmp -s $@ $@.tmp && rm -f $@.tmp || mv -f $@.tmp $@

But then - you only add a new #define to the build environment,
without any users of it, i. e. dead code.

Did you intend to post any code that would use this (in this case these
patches should be merged into one, or at least into a series), or can
we simply drop this patch?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Great teachers have small audiences while they are still alive.


More information about the U-Boot mailing list