[U-Boot] [PATCH] mx6dl: Add initial support for Wandboard dual lite
Wolfgang Denk
wd at denx.de
Sat Mar 9 23:14:38 CET 2013
Dear Fabio Estevam,
In message <1362861792-23032-1-git-send-email-festevam at gmail.com> you wrote:
>
> Add initial support for Wandboard dual lite.
Thanks!
> +int dram_init(void)
> +{
> + gd->ram_size = imx_ddr_size();
Can we please use get_ram_size() to verify / test the actual RAM size?
> +#define CONFIG_ARP_TIMEOUT 200UL
Is this really needed?
> +/* Physical Memory Map */
> +#define CONFIG_NR_DRAM_BANKS 1
> +#define PHYS_SDRAM MMDC0_ARB_BASE_ADDR
> +#define PHYS_SDRAM_SIZE (1u * 1024 * 1024 * 1024)
What is the "1u *" needed for?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If in any problem you find yourself doing an immense amount of work,
the answer can be obtained by simple inspection.
More information about the U-Boot
mailing list