[U-Boot] [PATCH v1] DOS_PBR block type is also valid dos block type.

Sonic Zhang sonic.adi at gmail.com
Tue Mar 12 03:59:22 CET 2013


Hi Stephen,

On Tue, Mar 12, 2013 at 1:28 AM, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 03/11/2013 03:56 AM, sonic.adi at gmail.com wrote:
>> From: Sonic Zhang <sonic.zhang at analog.com>
>>
>> - Should return 0 for both DOS_MBR and DOS_PBR block types in test_part_dos().
>
> What problem does this solve?
>
> I don't believe this change is correct. The purpose of test_part_dos()
> is to determine whether a block device contains an MS-DOS partition table.
>
> Such a partition table is present in an MBR, but not a PBR. A PBR
> contains a *FAT file-system, and does not include a partition table.

The SD card formated by windows 7 into one FAT partition can't be
initialized correct in u-boot function init_part() after you reuse the
function test_block_type() in function test_part_dos(). So, files on
that partition can't be displayed when running command "fatls mmc 0".

The only difference in your change is to mark dos partition with flag
DOS_PBR invalid.


Regards,

Sonic


More information about the U-Boot mailing list