[U-Boot] [PATCH 2/2] SPL: Fix build of CONFIG_SPL_NET_SUPPORT

Joe Hershberger joe.hershberger at gmail.com
Tue Mar 12 19:19:09 CET 2013


Hi Tom,

On Tue, Mar 12, 2013 at 11:16 AM, Tom Rini <trini at ti.com> wrote:
> With CONFIG_SPL_NET_SUPPORT set we bring in most of the environment
> related code.  This in turn means that while we discard the callback
> saftey checks in the environment, we had still needed their
> __start/__end linker symbols.  In most cases this had been working
> because we generated u-boot.lst for the main U-Boot build prior to
> creating u-boot-spl.lds.  With a sufficiently large machine this is not
> the case and exposed this latent bug which is that as of f8cfcf1 there
> are no callback linker entries so not __start/__end symbol was
> generated.
>
> As the environment is not user modifiable in this particular run-time
> (for any variable that had a callback associated with it) we simply
> provide an empty env_callback_init in SPL.
>
> Cc: Joe Hershberger <joe.hershberger at ni.com>
> Cc: Scott Wood <scottwood at freescale.com>
> Tested-by: Tom Rini <trini at ti.com> (Ran with am335x_evm_usbspl build)
> Signed-off-by: Tom Rini <trini at ti.com>
> ---

Acked-by: Joe Hershberger <joe.hershberger at ni.com>


More information about the U-Boot mailing list