[U-Boot] [PATCH v1 1/2] bfin: Remove spi dma function in bf5xx.

Scott Jiang scott.jiang.linux at gmail.com
Wed Mar 13 04:13:35 CET 2013


Mike,

test case is [#6887], if you save data and read out to compare it
sometimes fail.
I agree that we can keep this patch, but it introduces problems to
test engineer.
This is a random error, she is difficult to know which board and which case we
should enable this function.

2013/3/12 Mike Frysinger <vapier at gentoo.org>:
> On Monday 04 March 2013 02:20:08 Sonic Zhang wrote:
>> From: Scott Jiang <scott.jiang.linux at gmail.com>
>>
>> BF5xx rx dma causes spi flash random read error.
>> Accually spi controller has problems both on tx and rx dma.
>> So remove spi dma support in u-boot.
>
> this is wrong, and imo, unnecessary.  it's wrong because using DMA gains a lot
> of speed increases, and works for in many cases (i haven't seen cases where it
> didn't work, but i haven't been actively developing in the last year of
> course).  it's unnecessary because there's already a CONFIG_xxx option to
> disable it if your platform is having problems and you can't figure things out,
> and don't need the speed gains.
> -mike


More information about the U-Boot mailing list