[U-Boot] [PATCH v3] integrator: pass a Device Tree by default

[Linus Walleij]

On Wed, Mar 13, 2013 at 8:14 AM, Wolfgang Denk <wd at denx.de> wrote:

>> -#define CONFIG_SYS_LOAD_ADDR         0x7fc0  /* default load address */
>> +#define CONFIG_SYS_LOAD_ADDR         0x800   /* default load address */
>
> This appears to be an unrelated change.  It should be clearly
> documented, especially as users who just update U-Boot on their board
> may have to make this change manually.

OK moved this out to a separate patch. Not very important anyway, I just
never understood the very weird offset 0x7fc0, because when I tested it
any address sort of works...

Any hints on why it is (historically) set to 0x7fc0?

>> -#define CONFIG_BOOTDELAY     2
>> +#define CONFIG_BOOTDELAY     0
>
> This is also an undocumented change, and one that is changing the
> board behaviour for all users.  Is this really a good idea?

I just skipped this. Basically this is because there is no default boot
script on the Integrator/AP anyway, but let's take that as a separate
patch.

>>  #define CONFIG_BOOTARGS              "root=/dev/mtdblock0 console=ttyAM0 console=tty"
>> -#define CONFIG_BOOTCOMMAND   ""
>> +#define CONFIG_BOOTCOMMAND   "setenv serverip 192.168.1.100 ; " \
>> +  "setenv fdtaddr 0x00800000 ; " \
>> +  "echo \"\\\\$loadaddr = $loadaddr, \\\\$fdtaddr=$fdtaddr\" ; " \
>> +  "echo \"load binaries then: bootm $loadaddr - $fdtaddr\""
>
> We don't allow statis network parameter settings in config files,
>
> Also, your boot command just echos some text, then - the comments
> claims it would do somethign else.

OK I'll update the comment. The only idea with the echoed text is
to be helpful since you have to enter the boot sequence manually
on the Integrator/AP (since ethernet is not always available, as it
is on PCI).

>>  #define CONFIG_SERVERIP 192.168.1.100
>>  #define CONFIG_IPADDR 192.168.1.104
>
> Please get rid of these.  We don't allow this in board config files.

I'll try to convert this to using DHCP.

>> -#define CONFIG_BOOTFILE "uImage"
>> +#define CONFIG_BOOTARGS      "root=/dev/mtdblock0 console=ttyAMA0 console=tty ip=dhcp netdev=27,0,0xfc800000,0xfc800010,eth0 video=clcdfb:0"
>> +#define CONFIG_BOOTCOMMAND "setenv serverip 192.168.1.100 ; " \
>
> NAK. We don't allow this in board config files.

OK same thing.

>> +  "setenv fdtaddr 0x00800000 ; " \
>> +  "bootp $loadaddr $serverip:uImage ; " \
>> +  "bootp $fdtaddr $serverip:integratorcp.dtb ; " \
>> +  "bootm $loadaddr - $fdtaddr"
>
> Is it intentional that integratorap.h and integratorcp.h are now
> configured so differently?

Yes, the Integrator/CP has an ethernet adapter (SMSC91x) that we know will
always be available and preferred boot path.

The Integrator/AP has an optional Ethernet PCI card, but we cannot rely on that
always being present.

Thanks,
Linus Walleij