[U-Boot] [PATCH RESEND] mpc85xx: Fix a compiler warning when CONFIG_WATCHDOG is turned on

Wolfgang Denk wd at denx.de
Wed Mar 13 17:09:27 CET 2013


Dear Horst Kronstorfer,

In message <1363175243-12183-1-git-send-email-hkronsto at frequentis.com> you wrote:
> cpu.c:288:2:
> warning: implicit declaration of function 'reset_85xx_watchdog'
> [-Wimplicit-function-declaration]
...
> +void
> +watchdog_reset(void)
> +{
> +	int re_enable = disable_interrupts();
> +	reset_85xx_watchdog();
> +	if (re_enable) enable_interrupts();
> +}

When changing code, please fix the formatting as needed.  Here:
please add a blank line after the declarations, and put the
"enable_interrupts();" correctly indented on a new line.

And please start running your patches through checkpatch before
submitting - it would have complained, too:

ERROR: trailing statements should be on next line
#123: FILE: arch/powerpc/cpu/mpc85xx/cpu.c:298:
+       if (re_enable) enable_interrupts();

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
We are Microsoft. Unix is irrelevant. Openness is futile.  Prepare to
be assimilated.


More information about the U-Boot mailing list