[U-Boot] [PATCH] Tegra114: pinmux: Fix bad CAM_MCLK func 3 table entry

[Stephen Warren]

On 03/13/2013 04:10 PM, Tom Warren wrote:
> This caused CAM_MCLK's pinmux reg to be locked out, since the
> table parsing code couldn't find a matching entry for VI_ALT3
> and wrote garbage to the register.

> diff --git a/arch/arm/cpu/tegra114-common/pinmux.c b/arch/arm/cpu/tegra114-common/pinmux.c

> @@ -239,7 +239,7 @@ const struct tegra_pingroup_desc tegra_soc_pingroups[PINGRP_COUNT] = {

> -	PINI(CAM_MCLK,    CAM,     VI,         VI_ALT1,    VI_ALT2, RSVD4),
> +	PINI(CAM_MCLK,    CAM,     VI,         VI_ALT1,    VI_ALT3, RSVD4),

This doesn't seem right; the "alt" settings should be assigned in order
non-alt, alt1, alt2, alt3.

You say, "the table parsing code couldn't find a matching entry for
VI_ALT3". What was looking for that entry?

Also, shouldn't the pinmux driver be fixed not to write garbage to a
register, but instead return an error, if it can't find the table entry
it's looking for?