[U-Boot] [PATCH V4] nitrogen: Use unsigned long to specify the total RAM size

[Albert ARIBAUD]

Hi Stefano,

On Thu, 14 Mar 2013 15:09:15 +0100, Stefano Babic <sbabic at denx.de>
wrote:

> On 14/03/2013 14:15, Albert ARIBAUD wrote:
> > Hi Stefano,
> > 
> > On Thu, 14 Mar 2013 09:09:21 +0100, Stefano Babic <sbabic at denx.de>
> > wrote:
> > 
> >> From: "fabio.estevam at freescale.com" <fabio.estevam at freescale.com>
> >>
> >> When building for the nitrogen boards with 2GB the following warning happens:
> >>
> >> nitrogen6x.c:89:38: warning: integer overflow in expression [-Woverflow]
> >>
> >> 2GB can not fit in 32-bits, so use ulong instead.
> >>
> >> Reported-by: Albert Aribaud <albert.u.boot at aribaud.net>
> >> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> >> Signed-off-by: Stefano Babic <sbabic at denx.de>
> > 
> > This somehow is redundant with Fabio's patch 2/2 with the same summary,
> > right?
> > 
> 
> We sent quite at the same time - I will discharge mine.
> 
> > Stefano: once Fabio's series is OK,
> > 
> > - either you rollback your ToT, apply Fabio's series before it, and
> >   then send out an amended PR, which is more work but makes your tree
> >   build-clean;
> > 
> > - or I apply Fabio's series then your existing PR, which is less
> >   work but leaves your current ToT non-build-clean until you merge back
> >   from ARM (or mainline once I do my own PR).
> > 
> > What do you prefer? I would favor the first option, FWIW.
> 
> I prefer to apply Fabio's patches on top of u-boot-imx and send an
> amended PR. This is also my favorite option. What do you mean with
> rollback the ToT ? As I have already pushed on the server, I do not like
> to rebase it or things like that. My idea is only to apply the patches
> and send after that a new PR to you.

That's fine. :)

> Stefano

Amicalement,
-- 
Albert.