[U-Boot] [PATCH v4] Add initial support for Wandboard dual lite and solo.

[Fabio Estevam]

Hi Wolfgang,

On Thu, Mar 14, 2013 at 9:31 AM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Fabio Estevam,
>
> In message <1363228354-29534-1-git-send-email-festevam at gmail.com> you wrote:
>> From: Fabio Estevam <fabio.estevam at freescale.com>
>>
>> Add initial support for Wandboard.
>
> Subject and commit message are redundant, resulting in text like this:
>
>         Add initial support for Wandboard dual lite and solo.
>
>         Add initial support for Wandboard.
>
> Please remove the second line.

Thanks for the review. I will address your comments and send v5 after
the nitrogen patches are applied into u-boot.imx.

>> +#define CONFIG_BOOTDELAY            1
>
> Is there any reason for not chosing the more standard 5 second delay?

Ok, so let's go with 3 seconds then ;-)

> I can confirm that the code boots on a wanboard_dl system, but it does
> not find the environment as used by the original Technixion port. Is
> this intentional?

To be honest I haven't really checked the environment settings used in
the original Technixion port.

Hopefully this is not a problem.

> Can we please remove the "Reset cause: WDOG" line in production mode?

Do you mean the change below?

--- a/arch/arm/imx-common/cpu.c
+++ b/arch/arm/imx-common/cpu.c
@@ -148,7 +148,7 @@ int print_cpuinfo(void)
                (cpurev & 0x000F0) >> 4,
                (cpurev & 0x0000F) >> 0,
                mxc_get_clock(MXC_ARM_CLK) / 1000000);
-       printf("Reset cause: %s\n", get_reset_cause());
+       debug("Reset cause: %s\n", get_reset_cause());
        return 0;
 }
 #endif

Since this is common code I can address it separately with other
patch. Just let me know if this is OK.

Regards,

Fabio Estevam