[U-Boot] [PATCH 1/4 v6] Exynos: Add hardware accelerated SHA256 and SHA1
Simon Glass
sjg at chromium.org
Fri Mar 15 21:20:11 CET 2013
Hi Akshay,
On Fri, Mar 15, 2013 at 1:52 AM, Akshay Saraswat <akshay.s at samsung.com> wrote:
> SHA-256 and SHA-1 accelerated using ACE hardware.
>
> Signed-off-by: ARUN MANKUZHI <arun.m at samsung.com>
> Signed-off-by: Akshay Saraswat <akshay.s at samsung.com>
One nit below, but otherwise:
Acked-by: Simon Glass <sjg at chromium.org>
[...]
> Changes since v5:
> - Removed ace_sha.h.
> - Renamed ace_sfr.h as ace_sha.h.
> - Removed timeout and checking for PRNG_ERROR bit in HASH_STATUS register.
> PRNG_ERROR bit high means setup was not done properly. Since there is no
> way to detect faulty h/w, we consider the possible fact that h/w should
> not be able to setup feed properly if it's faulty.
> - Renamed function name ace_sha256 to hw_sha256 and ace_sha1 to hw_sha1.
>
> Makefile | 1 +
> arch/arm/include/asm/arch-exynos/ace_sha.h | 327 +++++++++++++++++++++++++++++
> arch/arm/include/asm/arch-exynos/cpu.h | 4 +
> drivers/crypto/Makefile | 47 +++++
> drivers/crypto/ace_sha.c | 129 ++++++++++++
> 5 files changed, 508 insertions(+)
> create mode 100644 arch/arm/include/asm/arch-exynos/ace_sha.h
> create mode 100644 drivers/crypto/Makefile
> create mode 100644 drivers/crypto/ace_sha.c
>
[...]
> diff --git a/drivers/crypto/ace_sha.c b/drivers/crypto/ace_sha.c
> new file mode 100644
> index 0000000..e8d9b2d
> --- /dev/null
> +++ b/drivers/crypto/ace_sha.c
> @@ -0,0 +1,129 @@
> +/*
> + * Advanced Crypto Engine - SHA Firmware
> + * Copyright (c) 2012 Samsung Electronics
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> + *
> + */
> +#include <common.h>
> +#include <sha256.h>
> +#include <sha1.h>
> +#include <asm/errno.h>
> +#include <asm/arch/clk.h>
> +#include <asm/arch/ace_sha.h>
> +
> +/* Maximum frequency supported by the SoC*/
> +#define MAX_FREQ (1.7 * 1000 * 1000 * 1000)
> +
> +/* SHA1 value for the message of zero length */
> +static const unsigned char sha1_digest_emptymsg[SHA1_SUM_LEN] = {
> + 0xDA, 0x39, 0xA3, 0xEE, 0x5E, 0x6B, 0x4B, 0x0D,
> + 0x32, 0x55, 0xBF, 0xFF, 0x95, 0x60, 0x18, 0x90,
> + 0xAF, 0xD8, 0x07, 0x09};
> +
> +/* SHA256 value for the message of zero length */
> +static const unsigned char sha256_digest_emptymsg[SHA256_SUM_LEN] = {
> + 0xE3, 0xB0, 0xC4, 0x42, 0x98, 0xFC, 0x1C, 0x14,
> + 0x9A, 0xFB, 0xF4, 0xC8, 0x99, 0x6F, 0xB9, 0x24,
> + 0x27, 0xAE, 0x41, 0xE4, 0x64, 0x9B, 0x93, 0x4C,
> + 0xA4, 0x95, 0x99, 0x1B, 0x78, 0x52, 0xB8, 0x55};
> +
> +int ace_sha_hash_digest(const unsigned char *pbuf, unsigned int buf_len,
> + unsigned char *pout, unsigned int hash_type)
Since you don't check the return value and it only ever return 0, you
may as well make this void.
> +{
> + unsigned int i, reg, len;
> + unsigned int *pdigest;
> + struct exynos_ace_sfr *ace_sha_reg =
> + (struct exynos_ace_sfr *)samsung_get_base_ace_sfr();
> +
> + if (buf_len == 0) {
> + /* ACE H/W cannot compute hash value for empty string */
> + if (hash_type == ACE_SHA_TYPE_SHA1)
> + memcpy(pout, sha1_digest_emptymsg, SHA1_SUM_LEN);
> + else
> + memcpy(pout, sha256_digest_emptymsg, SHA256_SUM_LEN);
> + return 0;
> + }
> +
> + /* Flush HRDMA */
> + writel(ACE_FC_HRDMACFLUSH_ON, &ace_sha_reg->fc_hrdmac);
> + writel(ACE_FC_HRDMACFLUSH_OFF, &ace_sha_reg->fc_hrdmac);
> +
> + /* Set byte swap of data in */
> + writel(ACE_HASH_SWAPDI_ON | ACE_HASH_SWAPDO_ON | ACE_HASH_SWAPIV_ON,
> + &ace_sha_reg->hash_byteswap);
> +
> + /* Select Hash input mux as external source */
> + reg = readl(&ace_sha_reg->fc_fifoctrl);
> + reg = (reg & ~ACE_FC_SELHASH_MASK) | ACE_FC_SELHASH_EXOUT;
> + writel(reg, &ace_sha_reg->fc_fifoctrl);
> +
> + /* Set Hash as SHA1 or SHA256 and start Hash engine */
> + reg = (hash_type == ACE_SHA_TYPE_SHA1) ?
> + ACE_HASH_ENGSEL_SHA1HASH : ACE_HASH_ENGSEL_SHA256HASH;
> + reg |= ACE_HASH_STARTBIT_ON;
> + writel(reg, &ace_sha_reg->hash_control);
> +
> + /* Enable FIFO mode */
> + writel(ACE_HASH_FIFO_ON, &ace_sha_reg->hash_fifo_mode);
> +
> + /* Set message length */
> + writel(buf_len, &ace_sha_reg->hash_msgsize_low);
> + writel(0, &ace_sha_reg->hash_msgsize_high);
> +
> + /* Set HRDMA */
> + writel((unsigned int)pbuf, &ace_sha_reg->fc_hrdmas);
> + writel(buf_len, &ace_sha_reg->fc_hrdmal);
> +
> + /* Check if status changes within given time limit */
> + while ((readl(&ace_sha_reg->hash_status) & ACE_HASH_MSGDONE_MASK) ==
> + ACE_HASH_MSGDONE_OFF) {
> + /*
> + * PRNG error bit goes HIGH if a PRNG request occurs without
> + * a complete seed setup. We are using this bit to check h/w
> + * because proper setup is not expected in that case.
> + */
> + if ((readl(&ace_sha_reg->hash_status)
> + & ACE_HASH_PRNGERROR_MASK) == ACE_HASH_PRNGERROR_ON)
> + break;
> + }
> +
> + /* Clear MSG_DONE bit */
> + writel(ACE_HASH_MSGDONE_ON, &ace_sha_reg->hash_status);
> +
> + /* Read hash result */
> + pdigest = (unsigned int *)pout;
> + len = (hash_type == ACE_SHA_TYPE_SHA1) ? SHA1_SUM_LEN : SHA256_SUM_LEN;
> +
> + for (i = 0; i < len / 4; i++)
> + pdigest[i] = readl(&ace_sha_reg->hash_result[i]);
> +
> + /* Clear HRDMA pending bit */
> + writel(ACE_FC_HRDMA, &ace_sha_reg->fc_intpend);
> +
> + return 0;
> +}
> +
> +void hw_sha256(const unsigned char *pbuf, unsigned int buf_len,
> + unsigned char *pout, unsigned int chunk_size)
> +{
> + ace_sha_hash_digest(pbuf, buf_len, pout, ACE_SHA_TYPE_SHA256);
> +}
> +
> +void hw_sha1(const unsigned char *pbuf, unsigned int buf_len,
> + unsigned char *pout, unsigned int chunk_size)
> +{
> + ace_sha_hash_digest(pbuf, buf_len, pout, ACE_SHA_TYPE_SHA1);
> +}
> --
> 1.8.0
>
Regards,
Simon
More information about the U-Boot
mailing list