[U-Boot] [PATCH 2/2] mx6qsabrelite: Do not hardcode the CPU revision

Dirk Behme dirk.behme at gmail.com
Sat Mar 16 06:59:41 CET 2013


Am 15.03.2013 22:06, schrieb Fabio Estevam:
> From: Fabio Estevam <fabio.estevam at freescale.com>
>
> Instead of hardcoding the CPU revision, it is better to use get_cpu_rev().

I think to remember that there is a reason why it is hard coded this 
way. Have you tested this with the Vivante GPU driver? If I remember 
correctly they check for exactly the 0x63000 and if it's not there, it 
won't work (?).

Best regards

Dirk

> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> ---
>   board/freescale/mx6qsabrelite/mx6qsabrelite.c |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/board/freescale/mx6qsabrelite/mx6qsabrelite.c b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> index 5b69a6d..9bd444e 100644
> --- a/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> +++ b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
> @@ -26,6 +26,7 @@
>   #include <asm/arch/imx-regs.h>
>   #include <asm/arch/iomux.h>
>   #include <asm/arch/mx6q_pins.h>
> +#include <asm/arch/sys_proto.h>
>   #include <asm/errno.h>
>   #include <asm/gpio.h>
>   #include <asm/imx-common/iomux-v3.h>
> @@ -300,7 +301,7 @@ int board_mmc_init(bd_t *bis)
>
>   u32 get_board_rev(void)
>   {
> -	return 0x63000 ;
> +	return get_cpu_rev();
>   }
>
>   #ifdef CONFIG_MXC_SPI
>



More information about the U-Boot mailing list