[U-Boot] [PATCH v8] Introduced btrfs file-system with btrload command

Tom Rini trini at ti.com
Tue Mar 19 15:35:04 CET 2013


On Mon, Mar 18, 2013 at 01:23:20PM +0000, Adnan Ali wrote:

> Introduces btrfs file-system to read file from
> volume/sub-volumes with btrload command. This
> implementation has read-only support.
> This btrfs implementation is based on syslinux btrfs
> code, commit 269ebc845ebc8b46ef4b0be7fa0005c7fdb95b8d.
> 
> v8:     patch re-formated.
> v7:     patch re-formated.
> v6:     patch re-formated.
> v5:     merged with master.
> v4:     btrls command added.
> 
> Signed-off-by: Adnan Ali <adnan.ali at codethink.co.uk>

I'm sorry, but there's still some pretty severe checkpatch warnings
introduced here over syslinux such as:
ERROR: do not use assignment in if condition
#525: FILE: btrfs/btrfs.c:525:
+                               if (status = btrfs_comp_keys_type(&search_key,

Please use "./tools/checkpatch.pl -f fs/btrfs/btrfs.c" and -f
/path/to/syslinux/core/fs/btrfs/btrfs.c and fix the things that are
being introduced and quite possibly bugs like the above.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130319/cd1e67f8/attachment.pgp>


More information about the U-Boot mailing list