[U-Boot] [PATCH v8] Introduced btrfs file-system with btrload command

Tom Rini trini at ti.com
Tue Mar 19 16:28:34 CET 2013


On Tue, Mar 19, 2013 at 03:25:47PM +0000, Adnan Ali wrote:
> Hi
> 
> On 19/03/13 14:35, Tom Rini wrote:
> >On Mon, Mar 18, 2013 at 01:23:20PM +0000, Adnan Ali wrote:
> >
> >>Introduces btrfs file-system to read file from
> >>volume/sub-volumes with btrload command. This
> >>implementation has read-only support.
> >>This btrfs implementation is based on syslinux btrfs
> >>code, commit 269ebc845ebc8b46ef4b0be7fa0005c7fdb95b8d.
> >>
> >>v8:     patch re-formated.
> >>v7:     patch re-formated.
> >>v6:     patch re-formated.
> >>v5:     merged with master.
> >>v4:     btrls command added.
> >>
> >>Signed-off-by: Adnan Ali <adnan.ali at codethink.co.uk>
> >I'm sorry, but there's still some pretty severe checkpatch warnings
> >introduced here over syslinux such as:
> >ERROR: do not use assignment in if condition
> >#525: FILE: btrfs/btrfs.c:525:
> >+                               if (status = btrfs_comp_keys_type(&search_key,
> >
> >Please use "./tools/checkpatch.pl -f fs/btrfs/btrfs.c" and -f
> >/path/to/syslinux/core/fs/btrfs/btrfs.c and fix the things that are
> >being introduced and quite possibly bugs like the above.
> >
>      Thanks, I am going to remove all the errors. Do you want me to
> remove all
> warnings as well or you are fine with it. This has taken quite a while now.

Yes please fix all of the new warnings and errors that are not found in
syslinux sources.  Thanks.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130319/47e9918b/attachment.pgp>


More information about the U-Boot mailing list