[U-Boot] [PATCH 1/2] mmc: mmc_getcd/getwp: use sensible defaults

Peter Korsgaard jacmet at sunsite.dk
Thu Mar 21 15:46:11 CET 2013


>>>>> "Tom" == Tom Rini <trini at ti.com> writes:

 Tom> On Thu, Mar 21, 2013 at 03:00:03PM +0100, Peter Korsgaard wrote:
 >> Let mmc_getcd() return true and mmc_getwp() false if mmc driver doesn't
 >> provide handlers for them.
 >> 
 >> Signed-off-by: Peter Korsgaard <peter.korsgaard at barco.com>

 Tom> Do we really need to do this?  It seems like we should be working
 Tom> correctly here already, or we also need to fixup the weak function
 Tom> and/or the callers too.

Well, for omap_hsmmc we currently return -1, which is kind of okay for
getcd(), but if getwp() ever gets used it means we cannot write to
cards.

-- 
Bye, Peter Korsgaard


More information about the U-Boot mailing list