[U-Boot] [PATCH 2/8] patman: Don't look for tags inside quotes

Doug Anderson dianders at chromium.org
Thu Mar 21 17:50:01 CET 2013


Simon,

On Wed, Mar 20, 2013 at 7:42 PM, Simon Glass <sjg at chromium.org> wrote:
>  # Separates a tag: at the beginning of the subject from the rest of it
> -re_subject_tag = re.compile('([^:]*):\s*(.*)')
> +re_subject_tag = re.compile('([^:"]*):\s*(.*)')

I'd go further and prevent all spaces.
  re_subject_tag = re.compile('([^:\s]*):\s*(.*)')

I ran into a similar problem with my patch I sent up earlier:

  patman: Add Cover-letter-cc: tag to Cc cover letter to people

I "fixed" that by removing the extra colon, but that was sorta lame.
We shouldn't have tags with spaces in them anyway...

  patman: Add Cover-letter-cc tag to Cc cover letter to people


-Doug


More information about the U-Boot mailing list