[U-Boot] [PATCH v2 3/4][resend] arm: at91: add at91sam9n12ek board support

[Bo Shen]

Hi Josh,
   minor comment as following.

On 3/21/2013 9:52, Josh Wu wrote:
> Add support for following features:
>    - nand boot, with PMECC 2bit ECC for 512 bytes sector
>    - SPI flash boot
>    - SD card boot
>    - LCD support
>
> Signed-off-by: Josh Wu <josh.wu at atmel.com>
> ---
>   MAINTAINERS                                       |    3 +
>   arch/arm/cpu/arm926ejs/at91/Makefile              |    1 +
>   arch/arm/cpu/arm926ejs/at91/at91sam9n12_devices.c |  180 ++++++++++++++++
>   arch/arm/cpu/arm926ejs/at91/clock.c               |    4 +-
>   board/atmel/at91sam9n12ek/Makefile                |   52 +++++
>   board/atmel/at91sam9n12ek/at91sam9n12ek.c         |  228 ++++++++++++++++++++
>   boards.cfg                                        |    3 +
>   include/configs/at91sam9n12ek.h                   |  232 +++++++++++++++++++++
>   8 files changed, 701 insertions(+), 2 deletions(-)
>   create mode 100644 arch/arm/cpu/arm926ejs/at91/at91sam9n12_devices.c
>   create mode 100644 board/atmel/at91sam9n12ek/Makefile
>   create mode 100644 board/atmel/at91sam9n12ek/at91sam9n12ek.c
>   create mode 100644 include/configs/at91sam9n12ek.h
>

[snip]

> +#ifdef CONFIG_LCD
> +void at91_lcd_hw_init(void)
> +{
> +	struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC;
> +
> +	at91_set_a_periph(AT91_PIO_PORTC, 24, 0);	/* LCDDPWR */
> +	at91_set_a_periph(AT91_PIO_PORTC, 26, 0);	/* LCDVSYNC */
> +	at91_set_a_periph(AT91_PIO_PORTC, 27, 0);	/* LCDHSYNC */
> +	at91_set_a_periph(AT91_PIO_PORTC, 28, 0);	/* LCDDOTCK */
> +	at91_set_a_periph(AT91_PIO_PORTC, 29, 0);	/* LCDDEN */
> +	at91_set_a_periph(AT91_PIO_PORTC, 30, 0);	/* LCDDOTCK */
> +
> +	at91_set_a_periph(AT91_PIO_PORTC, 0, 0);	/* LCDD0 */
> +	at91_set_a_periph(AT91_PIO_PORTC, 1, 0);	/* LCDD1 */
> +	at91_set_a_periph(AT91_PIO_PORTC, 2, 0);	/* LCDD2 */
> +	at91_set_a_periph(AT91_PIO_PORTC, 3, 0);	/* LCDD3 */
> +	at91_set_a_periph(AT91_PIO_PORTC, 4, 0);	/* LCDD4 */
> +	at91_set_a_periph(AT91_PIO_PORTC, 5, 0);	/* LCDD5 */
> +	at91_set_a_periph(AT91_PIO_PORTC, 6, 0);	/* LCDD6 */
> +	at91_set_a_periph(AT91_PIO_PORTC, 7, 0);	/* LCDD7 */
> +	at91_set_a_periph(AT91_PIO_PORTC, 8, 0);	/* LCDD8 */
> +	at91_set_a_periph(AT91_PIO_PORTC, 9, 0);	/* LCDD9 */
> +	at91_set_a_periph(AT91_PIO_PORTC, 10, 0);	/* LCDD10 */
> +	at91_set_a_periph(AT91_PIO_PORTC, 11, 0);	/* LCDD11 */
> +	at91_set_a_periph(AT91_PIO_PORTC, 12, 0);	/* LCDD12 */
> +	at91_set_a_periph(AT91_PIO_PORTC, 13, 0);	/* LCDD13 */
> +	at91_set_a_periph(AT91_PIO_PORTC, 14, 0);	/* LCDD14 */
> +	at91_set_a_periph(AT91_PIO_PORTC, 15, 0);	/* LCDD15 */
> +	at91_set_a_periph(AT91_PIO_PORTC, 16, 0);	/* LCDD16 */
> +	at91_set_a_periph(AT91_PIO_PORTC, 17, 0);	/* LCDD17 */
> +	at91_set_a_periph(AT91_PIO_PORTC, 18, 0);	/* LCDD18 */
> +	at91_set_a_periph(AT91_PIO_PORTC, 19, 0);	/* LCDD19 */
> +	at91_set_a_periph(AT91_PIO_PORTC, 20, 0);	/* LCDD20 */
> +	at91_set_a_periph(AT91_PIO_PORTC, 21, 0);	/* LCDD21 */
> +	at91_set_a_periph(AT91_PIO_PORTC, 22, 0);	/* LCDD22 */
> +	at91_set_a_periph(AT91_PIO_PORTC, 23, 0);	/* LCDD23 */
> +
> +	writel(1 << ATMEL_ID_LCDC, &pmc->pcer);
> +}
> +#endif
> +
> +
> +

when apply this patch, it will show following warning:

.git/rebase-apply/patch:225: new blank line at EOF.
+
warning: 1 line adds whitespace errors.

Best Regards,
Bo Shen