[U-Boot] [PATCH v2 3/4][resend] arm: at91: add at91sam9n12ek board support
Andreas Bießmann
andreas.devel at googlemail.com
Fri Mar 22 12:18:42 CET 2013
Dear Josh Wu,
you'd better used v3 for this patch. It is easier to dsitinguish the
patches than and it is allowed to send a single patch in a series in a
newer version.
You could use patman to manage your patches. I have to confess that I
never used it, but I should have a look for it.
On 03/21/2013 02:52 AM, Josh Wu wrote:
> Add support for following features:
> - nand boot, with PMECC 2bit ECC for 512 bytes sector
> - SPI flash boot
> - SD card boot
> - LCD support
>
> Signed-off-by: Josh Wu <josh.wu at atmel.com>
> ---
> MAINTAINERS | 3 +
> arch/arm/cpu/arm926ejs/at91/Makefile | 1 +
> arch/arm/cpu/arm926ejs/at91/at91sam9n12_devices.c | 180 ++++++++++++++++
> arch/arm/cpu/arm926ejs/at91/clock.c | 4 +-
> board/atmel/at91sam9n12ek/Makefile | 52 +++++
> board/atmel/at91sam9n12ek/at91sam9n12ek.c | 228 ++++++++++++++++++++
> boards.cfg | 3 +
> include/configs/at91sam9n12ek.h | 232 +++++++++++++++++++++
> 8 files changed, 701 insertions(+), 2 deletions(-)
> create mode 100644 arch/arm/cpu/arm926ejs/at91/at91sam9n12_devices.c
> create mode 100644 board/atmel/at91sam9n12ek/Makefile
> create mode 100644 board/atmel/at91sam9n12ek/at91sam9n12ek.c
> create mode 100644 include/configs/at91sam9n12ek.h
<snip>
> diff --git a/arch/arm/cpu/arm926ejs/at91/clock.c b/arch/arm/cpu/arm926ejs/at91/clock.c
> index f825388..5b4923f 100644
> --- a/arch/arm/cpu/arm926ejs/at91/clock.c
> +++ b/arch/arm/cpu/arm926ejs/at91/clock.c
> @@ -156,7 +156,7 @@ int at91_clock_init(unsigned long main_clock)
> */
> mckr = readl(&pmc->mckr);
> #if defined(CONFIG_AT91SAM9G45) || defined(CONFIG_AT91SAM9M10G45) \
> - || defined(CONFIG_AT91SAM9X5)
> + || defined(CONFIG_AT91SAM9N12) || defined(CONFIG_AT91SAM9X5)
> /* plla divisor by 2 */
> gd->arch.plla_rate_hz /= (1 << ((mckr & 1 << 12) >> 12));
Can you please re-arrange the patches here and add the 'at91: clock:
remove chip macro for plla_div2' before this patch. So we wouldn't need
to add the macro here and remove it in the next patch.
<snip>
Rest looks good to me.
Best regards
Andreas Bießmann
More information about the U-Boot
mailing list