[U-Boot] Patch sets coming

[Wolfgang Denk]

Dear York Sun,

In message <1363970293-21228-1-git-send-email-yorksun at freescale.com> you wrote:
> 
> Andy,
> 
> I am sending out several sets of backlog patches. Some of them may have been
> sent before. To make them easier to apply, here they come in sets.
> 
> In case my git send-email fails to add the author(s) to the CC list, please add
> them when you reply (it happened before).

It would be _really_ nice if you could get used to running your
patches through checkpatch _before_ posting these.

I see again a number of checkpatch issues, like:

WARNING: quoted string split across lines
#149: FILE: board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c:456:
+                       printf("WARNING: could not find compatible node"
+                               " %s: %s.\n", soc_elbc_compat,

CHECK: Alignment should match open parenthesis
#156: FILE: board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c:463:
+                       printf("WARNING: could not remove %s: %s.\n",
+                               soc_elbc_compat, fdt_strerror(err));

WARNING: quoted string split across lines
#167: FILE: board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c:474:
+               printf("WARNING: could not find compatible node"
+                       "%s: %s.\n", soc_usb_compat,

WARNING: quoted string split across lines
#175: FILE: board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c:482:
+               printf("WARNING: could not find compatible node"
+                       " %s: %s.\n", soc_usb_compat,

CHECK: Alignment should match open parenthesis
#182: FILE: board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c:489:
+               printf("WARNING: could not remove %s: %s.\n",
+                       soc_usb_compat, fdt_strerror(err));

ERROR: Unrecognized email address: 'Timur Tabi'
#116: 
Signed-off-by: Timur Tabi

CHECK: No space is necessary after a cast
#178: FILE: board/freescale/p1_p2_rdb_pc/spl_minimal.c:85:
+#elif defined(CONFIG_P1021RDB)
+       par_io_t *par_io = (par_io_t *) &(gur->qe_par_io);
ERROR: Unrecognized email address: 'Timur Tabi'
#122: 
Signed-off-by: Timur Tabi


Can you please fix these?

Thanks.

NAK for the series unless these issues are fixed.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I don't know if it's what you want, but it's what you get.  :-)
                      - Larry Wall in <10502 at jpl-devvax.JPL.NASA.GOV>