[U-Boot] [PATCH 09/23] Fman/t4240: some fix for 10G XAUI

Wolfgang Denk wd at denx.de
Fri Mar 22 21:48:55 CET 2013


Dear York Sun,

In message <1363972531-25641-9-git-send-email-yorksun at freescale.com> you wrote:
> From: Shaohui Xie <Shaohui.Xie at freescale.com>
> 
> 1. fix 10G mac offset by plus 8;
> 2. add second 10G port info for FM1 & FM2 when init ethernet info;
> 3. fix 10G lanes name to match lane protocol table;
> 
> Signed-off-by: Shaohui Xie <Shaohui.Xie at freescale.com>
> Signed-off-by: Roy Zang <tie-fei.zang at freescale.com>
> ---
>  drivers/net/fm/eth.c   |    2 ++
>  drivers/net/fm/init.c  |    6 ++++++
>  drivers/net/fm/t4240.c |   14 ++++++++++----
>  include/fm_eth.h       |    4 ++--
>  4 files changed, 20 insertions(+), 6 deletions(-)

CHECK: Alignment should match open parenthesis
#164: FILE: drivers/net/fm/t4240.c:74:
+       if ((port == FM1_10GEC1 || port == FM1_10GEC2) &&
+                       ((is_serdes_configured(XAUI_FM1_MAC9)) ||

CHECK: Alignment should match open parenthesis
#173: FILE: drivers/net/fm/t4240.c:81:
+       if ((port == FM2_10GEC1 || port == FM2_10GEC2) &&
+                       ((is_serdes_configured(XAUI_FM2_MAC9)) ||

Please fix.

And run your patches through checkpatch !!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
CAUTION:  The Mass of This Product Contains the Energy Equivalent  of
85 Million Tons of TNT per Net Ounce of Weight.


More information about the U-Boot mailing list