[U-Boot] [PATCH 03/31] net/phy: fix select line for TN80xx

Wolfgang Denk wd at denx.de
Fri Mar 22 21:59:30 CET 2013


Dear York Sun,

In message <1363973369-26110-3-git-send-email-yorksun at freescale.com> you wrote:
> From: Shaohui Xie <Shaohui.Xie at freescale.com>
> 
> TN80xx has same PHY ID as TN2020, but it needs different setting to register
> 30.93 which used to select line, so we read register 30.32 which has
> bit 15:12 to indicate PHY hardware version, for TN20xx we will get 3 or 2,
> for TN80xx we will get 5 or 4.
> 
> Signed-off-by: Shaohui Xie <Shaohui.Xie at freescale.com>
> ---
>  drivers/net/phy/teranetics.c |   15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)

CHECK: braces {} should be used on all arms of this statement
#136: FILE: drivers/net/phy/teranetics.c:46:
+               if (phy_hwversion <= 3) {
[...]
+               } else
[...]


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Even if you can deceive people about  a  product  through  misleading
statements, sooner or later the product will speak for itself.
- Hajime Karatsu


More information about the U-Boot mailing list