[U-Boot] [PATCH 05/31] powerpc/t4240qds: Add VDD override

[Wolfgang Denk]

Dear York Sun,

In message <1363973369-26110-5-git-send-email-yorksun at freescale.com> you wrote:
> Allow VDD voltage overriding with a command. This is an add-on feasture of
> VID. To override VDD, use command vdd_override with the value of voltage
> in mV, for example
> 
> vdd_override <voltage in mV, eg. 1050>
> 
> The above example will set the VDD to 1.050 volt. Any wrong value out of
> range of 0.8188 to 1.2125 volt or invalid string is ignored.
> 
> In addition to the command, if overriding VDD is needed earlier in booting
> process, save an variable and reboot:
> 
> setenv t4240qds_vdd_mv <voltage in mV>
> saveenv
> 
> Signed-off-by: York Sun <yorksun at freescale.com>
> ---
>  board/freescale/t4qds/t4qds.c |   39 +++++++++++++++++++++++++++++++++++++--
>  doc/README.t4240qds           |   24 ++++++++++++++++++++++++
>  2 files changed, 61 insertions(+), 2 deletions(-)

CHECK: Alignment should match open parenthesis
#156: FILE: board/freescale/t4qds/t4qds.c:301:
+       if (vdd_override == 0 && vdd_string &&
+               !strict_strtoul(vdd_string, 10, &vdd_string_override))

WARNING: line over 80 characters
#182: FILE: board/freescale/t4qds/t4qds.c:821:
+static int do_vdd_adjust(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You!  What PLANET is this!
	-- McCoy, "The City on the Edge of Forever", stardate 3134.0