[U-Boot] [PATCH] env: fix potential stack overflow in environment functions

[Wolfgang Denk]

Dear Rob Herring,

In message <1363987581-28050-1-git-send-email-robherring2 at gmail.com> you wrote:
> 
> Most of the various environment functions create CONFIG_ENV_SIZE buffers on
> the stack. At least on ARM and PPC which have 4KB stacks, this can overflow
> the stack if we have large environment sizes. So move all the buffers off
> the stack to static buffers.

Could you please explain what exactly you mean with this "have 4KB
stacks" statement?

Also, why do you think there is more space for data then for stack?


Has this patch been tested on any actual hardware?

I would expect problems, as this code is running before relocation,
i. e. when the data segment is not writable?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
F u cn rd ths u cnt spl wrth a dm!