[U-Boot] Patch sets coming

[Tom Rini]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/22/2013 06:55 PM, York Sun wrote:
> On 03/22/2013 03:45 PM, Tom Rini wrote:
>> On Fri, Mar 22, 2013 at 02:43:28PM -0700, York Sun wrote:
>>> On 03/22/2013 02:25 PM, Tom Rini wrote:
>>>> On Fri, Mar 22, 2013 at 10:17:03PM +0100, Wolfgang Denk
>>>> wrote:
>>>>> Dear York Sun,
>>>>> 
>>>>> In message <514CC7B1.2070706 at freescale.com> you wrote:
>>>>>> 
>>>>>> Will fix. I often found unsure about some warnings, not
>>>>>> knowing if u-boot follow exactly the same standard.
>>>>>> Beside, some old patches may pass checkpatch then but
>>>>>> fails today.
>>>>> 
>>>>> Well, you are supposed to run checkpatch _today_, before
>>>>> posting, and fix such issues.
>>>>> 
>>>>> There may be a few cases where you intentionally ignore
>>>>> such fixes (like lines over 80 characters in tables of
>>>>> pin-muxc initializations, where wrapping the code would
>>>>> make it even worse to read), but such exceptions and your
>>>>> reasoning should be metioned in the comments.
>>>> 
>>>> To be clear, I know of 2 cases checkpatch.pl gets wrong today
>>>> and I have patches for both to push to correct this: 
>>>> http://patchwork.ozlabs.org/patch/228173/ 
>>>> http://patchwork.ozlabs.org/patch/227717/
>>>> 
>>>> Aside from that, it's once again checkpatch is correct unless
>>>> obviously wrong (first patch for example) and we should fix
>>>> .checkpatch.conf so it stops being wrong.
>>>> 
>>> How do I get rid of the "line over 80 characters" warning by
>>> fixing "quoted string split across lines"?
>>> 
>>> checkpatch log shows
>>> 
>>>> checkpatch: check for quoted strings broken across lines
>>>> 
>>>> checkpatch already makes an exception to the 80-column rule
>>>> for quoted strings, and Documentation/CodingStyle recommends
>>>> not splitting quoted strings across lines, because it breaks
>>>> the ability to grep for the string.  Rather than just
>>>> permitting this, actively warn about quoted strings split
>>>> across lines.
>>> 
>>> How do I activate the exception for quoted strings?
>> 
>> Well, it has exceptions for print function within the kernel.
>> The second patch I linked added an exception for 'debug' which
>> the kernel doesn't use (anymore).
>> 
> 
> So instead of a printk, we need a print for u-boot. Is that going
> to happen?

What line, exactly, is checkpatch.pl choking on in a patch when it
shouldn't?  Check out that second patch again, there's list of log
functions and everything should be caught correctly and not warned
about, but maybe something else is also missing.

- -- 
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRTQC5AAoJENk4IS6UOR1WLfoQALDYiqBKDtYSI5bGGpyZ3KiE
Y2K6TCz+v4Vw/oGiUW68+QFrhd84aXgQNPJjl6vzwVwXANi/WoKohd7Y0pTSPwIN
EmDEB10i/ToPG9VUGQznEAx0mj2yidE5IfkTFXlQUZepZFrnG58HN7xUlS+qI0f+
+m76r7PhtJe79qrxlKU9f3Z4OyWY8N8cm07KJKMEZF2lk+TJh8OKrsYBCT4Rknz4
feLyHOhpFWPXVE9SddJx269Ztex7hkenqtTahdC5BhbiIkEzvoYDh0ytV/Q60SKe
sH1+WisYtjYcsPAL3rI0vqvb0Uk79vhELl++hpH9H89pxsgZOjHO2BTxt+7UQLQL
a5eLf1VLEXmDgCWL3fkFOH79ik2EdCCLzGqoYbHNgUWPkXSzsdMHuXRb2QWZkqHT
n3dWiuSz8LtcRsM3triNjXbuaNM4FkcZb6cJ4woA8iVg9wDHaPtmMF7W87gLTb33
/gJuSP5jHJb6rpYKklFI6O9HH77WuiRz9MtcX1rIeiLAz3mMdzzp+El1kEkl5kGl
t79cVQRekj6RBuVZNH/70pRHrg6njbIsUEViZpHb8ZBBBEslw2Vbk36vLMCdlR82
dAkQcKLSooipK1hewdfSZLeN8cULz8ruOe9U0+O19VynXXoEwYSqKzpqqZN34Lg3
UVKg07bv1HWXY8BfcUYW
=uIY6
-----END PGP SIGNATURE-----