[U-Boot] [Patch v2] PHY: micrel.c: add support for KSZ9031

David Andrey David.Andrey at netmodule.com
Mon Mar 25 21:39:12 CET 2013


Hi Stefan,

> Why don't you just change the mask to support both PHY's with one
struct here? Something like this:
>
>  static struct phy_driver ksz9021_driver = {
> -	.name = "Micrel ksz9021",
> +	.name = "Micrel ksz90x1",
>  	.uid  = 0x221610,
> -	.mask = 0xfffff0,
> +	.mask = 0xffffc0,
>
> This would be much "simpler". Does it work for you?

Well, because the ksz9031 works well with the generic phy config
function. See ksz9021_config vs genphy_config

Regards
David


More information about the U-Boot mailing list