[U-Boot] [PATCH 4/5] part/dev_desc: Add log2 of Blocksize to block_dev_desc data struct.

Wolfgang Denk wd at denx.de
Tue Mar 26 12:31:56 CET 2013


Dear egbert.eich at googlemail.com,

In message <1364285735-2364-5-git-send-email-egbert.eich at gmail.com> you wrote:
> From: Egbert Eich <eich at suse.com>
> 
> This value serves as the shift value used to calculate the block number
> to read in file systems when implementing aviable block sizes.
> 
> Signed-off-by: Egbert Eich <eich at suse.com>
> ---
>  common/cmd_ide.c          |    4 ++++
>  common/cmd_sata.c         |    1 +
>  common/cmd_scsi.c         |    2 ++
>  common/usb_storage.c      |    1 +
>  drivers/block/ata_piix.c  |    1 +
>  drivers/block/pata_bfin.c |    1 +
>  drivers/block/systemace.c |    1 +
>  drivers/mmc/mmc.c         |    1 +
>  include/part.h            |    5 +++++
>  9 files changed, 17 insertions(+), 0 deletions(-)


WARNING: line over 80 characters
#127: FILE: common/cmd_ide.c:458:
+		ide_dev_desc[i].log2blksz = LOG2_INVALID(typeof(ide_dev_desc[i].log2blksz)); /* just init to an invalid value */

WARNING: line over 80 characters
#143: FILE: common/cmd_ide.c:1453:
+	dev_desc->log2blksz = LOG2_INVALID(typeof(dev_desc->log2blksz)); /* just init to an invalid value */

WARNING: line over 80 characters
#175: FILE: common/cmd_scsi.c:109:
+		scsi_dev_desc[i].log2blksz = LOG2_INVALID(typeof(scsi_dev_desc[i].log2blksz)); /* just init to an invalid value */

WARNING: line over 80 characters
#183: FILE: common/cmd_scsi.c:170:
+			scsi_dev_desc[scsi_max_devs].log2blksz = LOG2(scsi_dev_desc[scsi_max_devs].blksz);

WARNING: line over 80 characters
#219: FILE: drivers/block/pata_bfin.c:900:
+	sata_dev_desc[ap->port_no].log2blksz = LOG2(sata_dev_desc[ap->port_no].blksz);

total: 0 errors, 5 warnings, 101 lines checked

/home/wd/Mail/U-Boot/7152 has style problems, please review.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"It follows that any commander in chief who undertakes to carry out a
plan which he considers defective is at fault; he must put forth  his
reasons,  insist  of  the  plan being changed, and finally tender his
resignation rather than be the instrument of his army's downfall."
- Napoleon, "Military Maxims and Thought"


More information about the U-Boot mailing list