[U-Boot] [PATCH] cmd/gpt: Support gpt command for all devices.
Wolfgang Denk
wd at denx.de
Tue Mar 26 15:04:19 CET 2013
Dear egbert.eich at googlemail.com,
In message <1364288746-2597-1-git-send-email-egbert.eich at gmail.com> you wrote:
> From: Egbert Eich <eich at suse.com>
>
> The gpt command was only implemented for mmc devices. There is no reason
> why this command should not be generalized and be applied all other
> storage device classes.
> This change both simplifies the implementation and eliminates a
> build failure for systems that don't support mmcs.
>
> Signed-off-by: Egbert Eich <eich at suse.com>
> ---
> common/cmd_gpt.c | 43 ++++++++++++++++++-------------------------
> 1 files changed, 18 insertions(+), 25 deletions(-)
Please mark resubmits of new versions of patches as such; also, please
provide a change log so we can see what you actually changed. Please
see [1] for detailled instructions, and consider using patman to help
you doing this.
[1] http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
Note that this patch is still not checkpatch-clean:
WARNING: line over 80 characters
#195: FILE: common/cmd_gpt.c:310:
+ printf("%s: %s dev %d NOT available\n", __func__, argv[2], dev);
Please fix!!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As a general rule, the freedom of any people can be judged by the
volume of their laughter.
More information about the U-Boot
mailing list