[U-Boot] [PATCH 4/9 v2] Exynos: Avoid a divide by zero by specifying a non-zero period for pwm 4

Minkyu Kang mk7.kang at samsung.com
Thu Mar 28 06:53:04 CET 2013


On 28/02/13 19:59, Akshay Saraswat wrote:
> The pwm_config function in the exynos pwm driver divides by its period
> period parameter. A function was calling pwm_config with a 0ns period and a
> 0ns duty cycle. That doesn't actually make any sense physically, and results
> in a divide by zero in the driver. This change changes the paremters to be a

typo.
paremters -> parameter

> 100000ns period and duty cycle.
> 
> Test with command "sf probe 1:0; time sf read 40008000 0 1000".
> Try with different numbers of bytes and see that sane values are obtained
> Build and boot U-boot with this patch, backlight works properly.
> 
> Signed-off-by: Gabe Black <gabeblack at google.com>
> Signed-off-by: Akshay Saraswat <akshay.s at samsung.com>
> Acked-by: Simon Glass <sjg at chromium.org>
> ---
> Changes since v1:
>         - Added "Acked-by: Simon Glass".
> 
>  arch/arm/cpu/armv7/s5p-common/timer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/cpu/armv7/s5p-common/timer.c b/arch/arm/cpu/armv7/s5p-common/timer.c
> index de61405..6a0fa58 100644
> --- a/arch/arm/cpu/armv7/s5p-common/timer.c
> +++ b/arch/arm/cpu/armv7/s5p-common/timer.c
> @@ -58,7 +58,7 @@ int timer_init(void)
>  {
>  	/* PWM Timer 4 */
>  	pwm_init(4, MUX_DIV_4, 0);
> -	pwm_config(4, 0, 0);
> +	pwm_config(4, 100000, 100000);

0 is a numerator.
I think.. it doesn't matter.

>  	pwm_enable(4);
>  
>  	/* Use this as the current monotonic time in us */
> 

Thanks,
Minkyu Kang.


More information about the U-Boot mailing list