[U-Boot] [PATCH 8/8] Add TI816X evm board support

Tom Rini trini at ti.com
Thu Mar 28 22:49:59 CET 2013


On Thu, Mar 28, 2013 at 06:14:41PM +0100, TENART Antoine wrote:

> ---
>  MAINTAINERS                            |    4 +
>  arch/arm/include/asm/arch-am33xx/spl.h |    9 +
>  board/ti/ti816x/Makefile               |   48 ++
>  board/ti/ti816x/evm.c                  |  753 ++++++++++++++++++++++++++++++++

This file has a large number of style problems, both things I know
checkpatch will catch as well as inconsistent spacing throughout and
/*
 * All multiline comments must look
 * like this.
 */

[snip]
> +#define CONFIG_SYS_BAUDRATE_TABLE   { 110, 300, 600, 1200, 2400, \
> +4800, 9600, 14400, 19200, 28800, 38400, 56000, 57600, 115200 }

Please use the fallback table instead of this.  And I snipped it before
I recalled, but you also should have enough memory to keep longhelp :)

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130328/03a074ac/attachment.pgp>


More information about the U-Boot mailing list