[U-Boot] [PATCH] common/lcd.c: cleanup use of global variables

Anatolij Gustschin agust at denx.de
Fri Mar 29 11:56:45 CET 2013


Hello Wolfgang,

On Sat,  5 Jan 2013 20:45:48 +0100
Wolfgang Denk <wd at denx.de> wrote:

> lcd_color_fg and lcd_color_bg had to be declared in board specific
> code, but were not actually used there; in addition, we have getter /
> setter functions for these, which were not used either.
> 
> Get rid of the global variables, and use the getter function where
> needed (so far no setter calls are needed).
> 
> Signed-off-by: Wolfgang Denk <wd at denx.de>
> Cc: Alessandro Rubini <rubini at unipv.it>
> Cc: Anatolij Gustschin <agust at denx.de>
> Cc: Bo Shen <voice.shen at atmel.com>
> Cc: Haavard Skinnemoen <haavard.skinnemoen at atmel.com>
> Cc: Kyungmin Park <kyungmin.park at samsung.com>
> Cc: Marek Vasut <marek.vasut at gmail.com>
> Cc: Minkyu Kang <mk7.kang at samsung.com>
> Cc: Nikita Kiryanov <nikita at compulab.co.il>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Stelian Pop <stelian at popies.net>
> Cc: Tom Warren <twarren at nvidia.com>
> ---
>  arch/arm/cpu/pxa/pxafb.c      | 2 --
>  arch/powerpc/cpu/mpc8xx/lcd.c | 3 ---
>  board/mcc200/lcd.c            | 3 ---
>  common/lcd.c                  | 7 ++++---
>  drivers/video/amba.c          | 2 --
>  drivers/video/atmel_hlcdfb.c  | 2 --
>  drivers/video/atmel_lcdfb.c   | 2 --
>  drivers/video/exynos_fb.c     | 2 --
>  drivers/video/tegra.c         | 4 +---
>  include/lcd.h                 | 6 +++---
>  10 files changed, 8 insertions(+), 25 deletions(-)

Patch rebased and merged, thanks!

Anatolij


More information about the U-Boot mailing list