[U-Boot] [PATCH v3 07/16] sandbox: dts: Add a serial console node

[Simon Glass]

Hi Stephen,

On 31 July 2014 21:20, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 07/30/2014 03:49 AM, Simon Glass wrote:
>>
>> If the sandbox device tree is provided to U-Boot (with the -d flag) then
>> it
>> will use the device tree version in preference to the built-in device. The
>> only difference is the colour.
>
>
>> diff --git a/arch/sandbox/dts/sandbox.dts b/arch/sandbox/dts/sandbox.dts
>
>
>> +       uart0: serial {
>> +               compatible = "sandbox,serial";
>> +               u-boot,dm-pre-reloc;
>
>
> Shouldn't that be handled by the driver. It's certainly something that's
> only relevant to the internals of U-Boot, and hence inappropriate to put
> into DT.

Hence the u-boot prefix. This is described in the driver model docs. I
have found a work-around (which forces a driver to be inited pre-reloc
if none is found) but I'm not 100% happy with it.

>
>> +               text-colour = "cyan";
>
>
> That's property should likely have a uboot, prefix, since it's non-standard.

Can I not just declare a binding for 'sandbox,serial'?

Regards,
Simon