[U-Boot] [PATCH 1/4] Add option -r to env import to allow import of text files with CRLF as line endings

Alexander Holler holler at ahsoftware.de
Sat Aug 2 23:09:57 CEST 2014


Am 01.08.2014 14:08, schrieb Wolfgang Denk:
> Dear Alexander Holler,
>
> In message <1405352998-7707-2-git-send-email-holler at ahsoftware.de> you wrote:
>> When this option is enabled, CRLF is treated like LF when importing environments
>> from text files, which means CRs ('\r') in front of LFs ('\n') are just ignored.
>>
>> Drawback of enabling this option is that (maybe exported) variables which have
>> a trailing CR in their content will get imported without that CR. But this
>> drawback is very unlikely and the big advantage of letting Windows user create
>> a *working* uEnv.txt too is likely more welcome.
>
> Should we not, for reasons of symmetry, then also extend "env export"
> by such a "-r" option?

Sorry, but I don't follow the new features of u-boot that closely.

Is it already possible to save an exported environment as (text-)file to 
some storage? Such wasn't possible when I've implemented that -r for 
"env import" and it doesn't make much sense if an exported environment 
never reaches users.

Another problem would be to decide in which format to save the 
environment. Same magic (e.g. an env var set by "env import") would be 
necessary to decided in which format to save the environment.

Regards,

Alexander Holler


More information about the U-Boot mailing list