[U-Boot] [PATCH] Makefile: restore *_config target

Masahiro Yamada yamada.m at jp.panasonic.com
Mon Aug 4 03:51:16 CEST 2014


Hi Jeroen,



On Fri,  1 Aug 2014 21:28:54 +0200
Jeroen Hofstee <jeroen at myspectrum.nl> wrote:

> The switch to KConfig break the [board]_config target. This breaks
> backwards compatibility and hence all documentation about how to
> build u-boot is no longer valid. It is also annoying for general
> recipes to build u-boot as contained in buildroot, crochet, oe,
> poky, eldk etc. Hence restore the *_config target.


OK.


> cc: Tom Rini <trini at ti.com>
> cc: Masahiro Yamada <yamada.m at jp.panasonic.com>
> cc: Simon Glass <sjg at chromium.org>
> Signed-off-by: Jeroen Hofstee <jeroen at myspectrum.nl>
> ---
>  Makefile | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 5e49545..2a339aa 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -413,7 +413,7 @@ endif
>  version_h := include/generated/version_autogenerated.h
>  timestamp_h := include/generated/timestamp_autogenerated.h
>  
> -no-dot-config-targets := clean clobber mrproper distclean \
> +no-dot-config-targets := clean clobber %_config mrproper distclean \
>  			 help %docs check% coccicheck \
>  			 ubootversion backup tools-only


This change is not necessay at all, I think.



> @@ -436,6 +436,11 @@ ifeq ($(KBUILD_EXTMOD),)
>          endif
>  endif
>  
> +# Before the switch to KConfig the configure target was %_config instead
> +# of %_defconfig. Just reinvoke make to be backwards compatible.
> +%_config: FORCE
> +	$(Q)$(MAKE) $(@:_config=_defconfig)
> +
>  ifeq ($(mixed-targets),1)
>  # ===========================================================================
>  # We're called with mixed targets (*config and build targets).


Because <board>_config matches "%config" pattern at line 467,
could you modify scripts/multiconfig.py, please?



Best Regards
Masahiro Yamada



More information about the U-Boot mailing list