[U-Boot] [PATCH 18/18] arm: mx6: cm_fx6: add sata support

Marek Vasut marex at denx.de
Mon Aug 4 10:27:38 CEST 2014


On Monday, August 04, 2014 at 09:23:12 AM, Igor Grinberg wrote:
> Hi Marek,
> 
> On 08/03/14 17:10, Marek Vasut wrote:
> > On Sunday, August 03, 2014 at 09:34:48 AM, Nikita Kiryanov wrote:
> >> Add support for SATA.
> >> 
> >> Cc: Igor Grinberg <grinberg at compulab.co.il>
> >> Cc: Stefano Babic <sbabic at denx.de>
> >> Cc: Tom Rini <trini at ti.com>
> >> Signed-off-by: Nikita Kiryanov <nikita at compulab.co.il>
> > 
> > I'd just squash all the cf_mx6 patches into the "add cf_mx6 board" patch.
> 
> Well, I tend to disagree on this.
> I find extremely hard to review the "long long squashed into one patch"
> patches. It is much easier to review small, functionality oriented,
> patches.

You do have a valid point when it comes to review, all right. There's no point 
in keeping them separate when they're applied though. Tough decisions this is. 
Let's see what others think then .

Best regards,
Marek Vasut


More information about the U-Boot mailing list