[U-Boot] [PATCH] drivers: rtc: remove dead drivers

Masahiro Yamada yamada.m at jp.panasonic.com
Tue Aug 5 03:16:35 CEST 2014


Hi Tom,


On Mon, 4 Aug 2014 13:30:10 -0400
Tom Rini <trini at ti.com> wrote:

> On Wed, Jul 30, 2014 at 07:20:03PM +0900, Masahiro Yamada wrote:
> 
> > The following configs are not defined at all:
> > 
> >  - CONFIG_RTC_DS1388
> >  - CONFIG_RTC_ISL1208
> >  - CONFIG_RTC_MX27
> >  - CONFIG_RTC_PL031
> >  - CONFIG_RTC_RS5C372A
> >  - CONFIG_SYS_DS1388_TCR_VAL
> > 
> > Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
> 
> I'm inclined to NAK this.  I can't speak to MX27 (Stefano?) but in other
> cases those RTCs can be breadboarded up on other EVMs or otherwise
> used in things that aren't quite upstream.  My long term hope is to be
> able to enable these drivers when building for am335x_evm or whatever,
> to get some coverage on them, and to also enable some other RTC drivers
> which have been posted but I put into RFC or Deferred in patchwork since
> they didn't have a board using them.


OK.

We will have to create config options in drivers/rtc/Kconfig
in our next migration step.
So, my intention was to drop unnecessary macros beforehand.
But I do not know which one is really unnecessary
and I simply grepped for undefined macros.

It is a good thing you reviewed this patch
and I retract it.


Best Regards
Masahiro Yamada



More information about the U-Boot mailing list