[U-Boot] [PATCH 03/15] tegra: kconfig: move board select menu and common settings

[Masahiro Yamada]

Hi Stephen,


On Mon, 04 Aug 2014 12:12:56 -0600
Stephen Warren <swarren at wwwdotorg.org> wrote:

> On 08/04/2014 07:19 AM, Masahiro Yamada wrote:
> > Becuase the board select menu in arch/arm/Kconfig is too big,
> > move the Tegra board select menu to tegra/Kconfig.
> >
> > Insert the Tegra SoC select menu between the arch select and the
> > board select.
> >
> >   Architecture select
> >   |-- Tegra Platform (Tegra)
> >       |- Tegra SoC select (Tegra20 / 30 / 114 / 124)
> >          |- Board select
> >
> > Consolidate also common settings (CONFIG_SYS_CPU="armv7" and
> > CONFIG_SYS_SOC="tegra*") and always "select" CONFIG_SPL as follows:
> >
> >    config TEGRA
> >            bool
> >            select SPL
> 
> I briefly scanned this and it looks reasonable to me.
> 
> Acked-by: Stephen Warren <swarren at nvidia.com>
> 
> BTW, what's the "+S:CONFIG_TEGRA=y" syntax in the defconfig files? I don't recall seeing that in the kernel, where *_defconfig are generated by "make savedefconfig", and only contain lines saying "CONFIG_TEGRA=y" without the "+S:" prefix.



The defconfig syntax is special for U-Boot.

"+S:CONFIG_TEGRA=y" means
"CONFIG_TEGRA=y" is defined in SPL as well as in the normal image.

I chose to use prefixes such "+S:"
instead of haveing multiple defconfigs per board.

(IIRC, you mentioned you do not like to duplicate CONFIG_ARM=y or CONFIG_TEGRA=y
in beaver_defconfig and beaver_spl_defconfig.)


Best Regards
Masahiro Yamada