[U-Boot] [PATCH 6/7] sunxi: Kconfig: move common settings into a shared code block

[Ian Campbell]

On Tue, 2014-08-05 at 09:24 +0800, Chen-Yu Tsai wrote:
> On Tue, Aug 5, 2014 at 5:26 AM, Ian Campbell <ijc at hellion.org.uk> wrote:
> > On Fri, 2014-08-01 at 09:46 +0200, Hans de Goede wrote:
> >> SYS_CPU, SYS_BOARD and SYS_SOC are identical for all sunxi boards, move
> >> them to a shared code block.
> >>
> >> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> >
> > This is an improvement so:
> > Acked-by: Ian Campbell <ijc at hellion.org.uk>
> >
> > But eventually we could clean up even more, e.g.
> >
> > config SYS_CONFIG_NAME
> >         string
> >         default "sun4i" if TARGET_SUN4I
> >         default "sun5i" if TARGET_SUN5I
> >         etc
> >
> > Possibly even some things should be select'd rather than default'd.
> 
> Selected sounds better. :)

The main thing I know about select is that one needs to be very careful
about when it is used, since it can have odd side effects....

Ian.