[U-Boot] [PATCH v3 1/4] usb/gadget: fastboot: add sparse image definitions

Tom Rini trini at ti.com
Tue Aug 5 16:00:56 CEST 2014


On Thu, Jul 31, 2014 at 10:32:51AM -0700, Steve Rae wrote:
> 
> 
> On 14-07-30 06:25 PM, Marek Vasut wrote:
> >On Thursday, June 26, 2014 at 10:13:21 PM, Steve Rae wrote:
> >>- to prepare for the support of fastboot sparse images
> >>
> >>Signed-off-by: Steve Rae <srae at broadcom.com>
> >>---
> >>This file is ASIS from:
> >>
> >>https://raw.githubusercontent.com/AOSB/android_system_core/master/libspars
> >>e/sparse_format.h (commit 28fa5bc347390480fe190294c6c385b6a9f0d68b)
> >>except for the __UBOOT__ conditional include.
> >>
> >>Changes in v3: None
> >>Changes in v2: None
> >>
> >>  include/sparse_format.h | 58
> >>+++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 58
> >>insertions(+)
> >>  create mode 100644 include/sparse_format.h
> >>
> >>diff --git a/include/sparse_format.h b/include/sparse_format.h
> >>new file mode 100644
> >>index 0000000..21fbd05
> >>--- /dev/null
> >>+++ b/include/sparse_format.h
> >>@@ -0,0 +1,58 @@
> >>+/*
> >>+ * Copyright (C) 2010 The Android Open Source Project
> >>+ *
> >>+ * Licensed under the Apache License, Version 2.0 (the "License");
> >>+ * you may not use this file except in compliance with the License.
> >>+ * You may obtain a copy of the License at
> >>+ *
> >>+ *      http://www.apache.org/licenses/LICENSE-2.0
> >>+ *
> >>+ * Unless required by applicable law or agreed to in writing, software
> >>+ * distributed under the License is distributed on an "AS IS" BASIS,
> >>+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> >>implied. + * See the License for the specific language governing
> >>permissions and + * limitations under the License.
> >
> >Please use the SPDX licence identifiers (pelase see Licenses/README)?

And again, the license itself _is_ a problem.

[snip]
> To clarify:
> I am taking this file ASIS from the location stated in the commit
> message....
> Do we _really_ want to modify _anything_ in this file (especially
> when the content is not changing); or do we want to leaving it
> pristine?

I'd be fine with it being pristine if it was a GPL-compatible license.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140805/6f9b4bde/attachment.pgp>


More information about the U-Boot mailing list