[U-Boot] [PATCH v2 02/15] zynq: kconfig: move board select menu and commonsettings

[Masahiro Yamada]

Hi Michal,



On Wed, 6 Aug 2014 09:57:46 +0200
Michal Simek <michal.simek at xilinx.com> wrote:

> On 08/06/2014 08:49 AM, Masahiro Yamada wrote:
> > Hi Michal,
> > 
> > 
> > On Wed, 6 Aug 2014 08:39:47 +0200
> > Michal Simek <michal.simek at xilinx.com> wrote:
> > 
> >> Hi Masahiro,
> >>
> >> On 08/06/2014 05:17 AM, Masahiro Yamada wrote:
> >>> Becuase the board select menu in arch/arm/Kconfig is too big,
> >>> move the Zynq board select menu to zynq/Kconfig.
> >>>
> >>> Consolidate also common settings (CONFIG_SYS_CPU="armv7" and
> >>> CONFIG_SYS_SOC="zynq").
> >>>
> >>> Refactor board/xilinx/zynq/MAINTAINERS too.
> >>>
> >>> Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
> >>> Cc: Michal Simek <michal.simek at xilinx.com>
> >>> ---
> >>>
> >>> Changes in v2: None
> >>>
> >>>  arch/arm/Kconfig                   | 15 ++----
> >>>  arch/arm/cpu/armv7/zynq/Kconfig    | 43 +++++++++++++++++
> >>>  board/xilinx/zynq/Kconfig          | 95 --------------------------------------
> >>>  board/xilinx/zynq/MAINTAINERS      | 12 +----
> >>>  configs/zynq_microzed_defconfig    |  1 +
> >>>  configs/zynq_zc70x_defconfig       |  1 +
> >>>  configs/zynq_zc770_xm010_defconfig |  1 +
> >>>  configs/zynq_zc770_xm012_defconfig |  1 +
> >>>  configs/zynq_zc770_xm013_defconfig |  1 +
> >>>  configs/zynq_zed_defconfig         |  1 +
> >>>  include/configs/zynq-common.h      |  1 -
> >>>  11 files changed, 54 insertions(+), 118 deletions(-)
> >>>  create mode 100644 arch/arm/cpu/armv7/zynq/Kconfig
> >>>  delete mode 100644 board/xilinx/zynq/Kconfig
> >> One
> >> One thing I have noticed was that when I run
> >> [u-boot]$ make zynq_zc70x_defconfig
> >> ...
> >>
> >> there is incorrect CONFIG_DEFCONFIG_LIST setup
> >>
> >> [u-boot]$ head .config
> >> #
> >> # Automatically generated file; DO NOT EDIT.
> >> # U-Boot 2014.07 Configuration
> >> #
> >> CONFIG_DEFCONFIG_LIST="configs/sandbox_defconfig"
> > 
> > I assume you thought having sandbox_defconfig in ARM .config
> > is weird.
> 
> Not exactly this. My expectation was that when I use
> zynq_zc70x_defconfig that it will be listed there instead of sandbox one.
> Or just CONFIG_DEFCONFIG_LIST not there.
> 
> > But I think this is correct.
> > 
> > Unlike Linux,  defconfig has a flat structure in U-Boot
> > because ARCH=arm is not given from the command line.
> 
> Even if ARCH=arm is passed behavior is the same

Yes. Giving ARCH is meaningless in U-Boot.



> 
> Is DEFCONFIG_LIST used anywhere?
> I just want to know what is this for.

I set the default value just in case.
The only difference I noticed is "make savedefconfig".


If .config does not exist, "make savedefconfig" uses
DEFCONFIG_LIST as its default.


With "config DEFCONFIG_LIST",

$ rm -f .config*
$ make savedefconfig
scripts/kconfig/conf --savedefconfig=defconfig Kconfig
#
# using defaults found in configs/sandbox_defconfig
#


But if we comment out DEFCONFIG_LIST,


$ rm -f .config*
$ make savedefconfig
scripts/kconfig/conf --savedefconfig=defconfig Kconfig







Best Regards
Masahiro Yamada