[U-Boot] [PATCH 1/4] Add option -r to env import to allow import of text files with CRLF as line endings

Alexander Holler holler at ahsoftware.de
Wed Aug 6 12:28:46 CEST 2014


Am 06.08.2014 12:02, schrieb Alexander Holler:
> Am 06.08.2014 08:43, schrieb Wolfgang Denk:
>> Dear Alexander,
>>
>> In message <53DFDC99.2020206 at ahsoftware.de> you wrote:
>>>
>>> At least I've understood it such that nobody still has an objection=20
>>> against the new feature for "env import -t" (-r).
>>
>> I object if it would be added without maintaining symmetry with "env
>> export".
>
> As explained I don't know how to add symmetry. It's impossible to export
> text concurrently in both formats.
>
> And I will not write a patch (I don't need), if I have to assume I'm
> wasting my time because it will never reach any possible user. So
> without consensus about what such a symmetry feature for "env export"
> should be and how it will look like I will not spend the (little) time
> to write a patch, nor the much large time to discuss the patch afterwards.

Maybe it helps to explain my motivation to write the patch in the subject:

I've run into the problem once, when I had to use a Windows box to write 
an uEnv.txt, and it happens extremly seldom that I'm using Windows. But 
then I've seen several other people running into the same problem (which 
is extremly hard to identify as <CR> is usually invisible). So I though 
I'm nice and write a patch to help other people (because I can write 
such a patch and I don't need to spend much time to do so) and everyone 
will be happy about.

So to conclude I don't need the -r for "env import" myself and it just 
ended up with around a dozen mails where I had to defend and explain the 
patch. That isn't what motivates to spend time writing "maintainer 
friendly" patches and to submit them.

Regards,

Alexander Holler


More information about the U-Boot mailing list