[U-Boot] [PATCH] tools, scripts: refactor error-out statements of Python scripts

Igor Grinberg grinberg at compulab.co.il
Thu Aug 7 08:31:48 CEST 2014


Hi Masahiro,

On 08/07/14 06:51, Masahiro Yamada wrote:
> In Python, sys.exit() function can also take an object other
> than an integer.
> 
> If an integer is given to the argument, Python exits with the return
> code of it.  If a non-integer argument is given, Python output it
> to stderr and exits with the return code of 1.
> 
> That means,
> 
>     print >> sys.stderr, "Blah Blah"
>     sys.exit(1)
> 
> is equivalent to
> 
>     sys.exit("Blah Blah")
> 
> The latter is a useful shorthand.
> 
> Note:
> Some error messages in Buildman and Patman were output to stdout.
> But they should go to stderr.  They are also fixed by this commit.
> This is a nice side effect.
> 
> Signed-off-by: Masahiro Yamada <yamada.m at jp.panasonic.com>
> Cc: Simon Glass <sjg at chromium.org>

Haven't you decided to replace python scripts?

> ---
> 
>  scripts/mailmapper         |  3 +--
>  scripts/multiconfig.py     |  7 +------

At least the ones that are used during the build process.

>  tools/buildman/control.py  | 18 ++++++------------
>  tools/genboardscfg.py      | 16 +++++-----------
>  tools/patman/checkpatch.py |  5 ++---
>  tools/patman/patman.py     |  3 +--
>  6 files changed, 16 insertions(+), 36 deletions(-)

[...]

-- 
Regards,
Igor.


More information about the U-Boot mailing list