[U-Boot] [PATCH v3 2/4] usb/gadget: fastboot: add eMMC support for flash command

Pantelis Antoniou panto at antoniou-consulting.com
Thu Aug 7 15:28:14 CEST 2014


Hi Marek,

[snip]

>> I don't want to be the first to defined it for all of armv7....
> 
> Honestly, we should just enable this CONFIG_SYS_VSNPRINTF by default for the 
> good of humanity and all the things, since this unbounded string handling is 
> just evil (see how OpenSSL ended up, partly because of that ... and I am just 
> starting to see the pattern in all the security code). I don't want to go down 
> that road with U-Boot.
> 
> So, would you please cook a separate patch to enable this by default, so it 
> would spur the right kind of discussion on this matter ?
> 

We should enable this by default. Unbounded string handling scares me.

If we have problems with blowing over SPL size restrictions, perhaps have it
disabled only on those cases (that are known to have a problem).

>> And I really don't want to define it only only my boards running so that
>> they can run 'fastboot'
>> What do you suggest?
> 
> See above, thanks !

Regards

-- Pantelis



More information about the U-Boot mailing list