[U-Boot] [PATCH v2] Makefile: remove generated boards.cfg within make distclean

Masahiro YAMADA yamada.m at jp.panasonic.com
Tue Aug 12 00:52:54 CEST 2014


Hi Roger,

(ccing Simon)


2014-08-10 21:37 GMT+09:00 Roger Meier <roger at bufferoverflow.ch>:
> Signed-off-by: Roger Meier <roger at bufferoverflow.ch>
> CC: Masahiro Yamada <yamada.m at jp.panasonic.com>
> CC: Tom Rini <trini at ti.com>
> CC: Wolfgang Denk <wd at denx.de>
>
> ---
> Changes for v2:
>    - remove boards.cfg within make distclean instead of mrproper
>    - use mrproper instead of distclean within MAKEALL
> ---
>  MAKEALL  |    2 +-
>  Makefile |    3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)


I think it is OK as for MAKEALL.
But I am not sure it is safe for buildman, which also uses boards.cfg.


I just did grep under tools/buildman directory and
found some lines referring 'distclean'.

./builder.py:179:                        distclean - can be called to
clean source
./builder.py:275:                    result = self.Make(commit, brd,
'distclean', work_dir,
./builder.py:276:                            'distclean', *args, env=env)
./builder.py:700:            stage: Stage that we are at (distclean,
config, build)


Unfortunately, I am not an expert of buildman.
I suspect this patch has an impact on it, but I am not sure.
I think Simon can help you.



-- 
Best Regards
Masahiro Yamada


More information about the U-Boot mailing list